Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for clarity around creating KfDef YAML #1182

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

tmarkiewicz
Copy link

In the documentation, after clicking 'Create KfDef' the user is taken to a screen where they're shown the form view and given the option for YAML. This change adds clarity, as on a quick glance it would appear the YAML view is not there. Language was added to make this more obvious.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

In the documentation, after clicking 'Create KfDef' the user is taken to a screen where they're shown the form view and given the option for YAML. This change adds clarity, as on a quick glance it would appear the YAML view is not there. Language was added to make this more obvious.
@elyra-bot
Copy link

elyra-bot bot commented Jan 8, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende requested a review from akchinSTC January 8, 2021 20:32
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akchinSTC akchinSTC merged this pull request into elyra-ai:master Jan 11, 2021
@lresende lresende added this to the 2.0.0 milestone Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants