-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save as code snippet from editor selection #1186
Save as code snippet from editor selection #1186
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Awesome. Please tag me when the feature is ready for a test drive! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested different file types and various editors. One observation: it appears that the action is only enabled for "cells" that are in edit mode. For example, open a notebook with a rendered markdown cell, and select some text. The save option is disabled. Is this intentional?
Just tried locally and it worked well! +1 on Patrick's comment about not needing the cells to be in edit mode. Also, not sure if this is the desired behavior, but I think it could be good to add the behavior of saving an entire cell as a snippet if none of the text is selected. |
@ptitzler @marthacryan Thank you for your feedback. |
Resolves #1005
This PR implements the 'Save as Code Snippet' command.
Developer's Certificate of Origin 1.1