-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add resuse support #1204
Re-add resuse support #1204
Conversation
Also fix some miswrotten build lines for lsp support
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
How easy would be to enable CPU usage tracking as well? |
Also, do we need to enable the extension as we do with the others at https://github.com/elyra-ai/elyra/tree/master/etc/config/jupyter_server_config.d. It does seem that it gets enabled by the pip install, but just in case... |
I'll add it
I'll take a quick look and see how trivial or non-trivial this is, iirc it was non-trivial when it was in core |
@lresende added the config json file, but as for CPU tracking, it's not even in the lab extension currently. So it's non-trivial, but we could contribute it to the lab extension ourselves if we want to. It wouldn't be very difficult add, but It would still take a non-trivial amount of time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ai#1204) nbresuse UI code was moved from core JupyterLab into an extension within the resource utilization APIs and was also renamed and moved moved to the jupyter-server GitHub organization.
Fixes #1161
nbresuse UI code was moved from core lab into an extension within the api, which was renamed and moved to the juoyter-server org. In order to keep the UI in Elyra we need to add it manually like we do git
Also fix some miswritten build lines for lsp support
Developer's Certificate of Origin 1.1