Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add resuse support #1204

Merged
merged 4 commits into from
Jan 20, 2021
Merged

Re-add resuse support #1204

merged 4 commits into from
Jan 20, 2021

Conversation

ajbozarth
Copy link
Member

Fixes #1161

nbresuse UI code was moved from core lab into an extension within the api, which was renamed and moved to the juoyter-server org. In order to keep the UI in Elyra we need to add it manually like we do git

Also fix some miswritten build lines for lsp support

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Also fix some miswrotten build lines for lsp support
@ajbozarth ajbozarth added this to the 2.0.0 milestone Jan 16, 2021
@ajbozarth ajbozarth self-assigned this Jan 16, 2021
@elyra-bot
Copy link

elyra-bot bot commented Jan 16, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende
Copy link
Member

How easy would be to enable CPU usage tracking as well?

@lresende
Copy link
Member

Also, do we need to enable the extension as we do with the others at https://github.com/elyra-ai/elyra/tree/master/etc/config/jupyter_server_config.d. It does seem that it gets enabled by the pip install, but just in case...

@ajbozarth
Copy link
Member Author

Also, do we need to enable the extension as we do with the others at https://github.com/elyra-ai/elyra/tree/master/etc/config/jupyter_server_config.d. It does seem that it gets enabled by the pip install, but just in case...

I'll add it

How easy would be to enable CPU usage tracking as well?

I'll take a quick look and see how trivial or non-trivial this is, iirc it was non-trivial when it was in core

@ajbozarth
Copy link
Member Author

@lresende added the config json file, but as for CPU tracking, it's not even in the lab extension currently. So it's non-trivial, but we could contribute it to the lab extension ourselves if we want to. It wouldn't be very difficult add, but It would still take a non-trivial amount of time

Copy link
Member

@lresende lresende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged commit 104e265 into elyra-ai:master Jan 20, 2021
@ajbozarth ajbozarth deleted the resuse branch January 20, 2021 09:16
lresende pushed a commit to marthacryan/elyra that referenced this pull request Jan 23, 2021
…ai#1204)

nbresuse UI code was moved from core JupyterLab into an extension
within the resource utilization APIs and was also renamed and moved
moved to the jupyter-server GitHub organization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for jupyter-resource-usage
2 participants