Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change kernel name to display name #1224

Merged
merged 3 commits into from
Jan 23, 2021

Conversation

karlaspuldaro
Copy link
Member

Fixes #1223

Using kernel display names:
image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jan 21, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler
Copy link
Member

Would there ever be a case where no display name is defined for a kernel?

@kevin-bates
Copy link
Member

Thanks @karlaspuldaro. I agree with this, although I believe this is a departure from what is displayed as the kernel name in the notebook - so I suppose one could have a "consistency argument". Also, could you please include an applicable screenshot for the conda kernel? I believe they use a bracketed name of the conda env somewhere (prefix or suffix). I had no idea the kernel name was so obnoxious for conda kernels.

To @ptitzler's point, would it be possible to fall back to the kernel name in cases where there is no display name? Since there's no enforcement of this, it's possible to have a kernelspec w/o a display name. I wonder what the launcher shows in such cases, since the launcher shows display names. (confirmed: it doesn't display any text, just the registered icon.)

@karlaspuldaro
Copy link
Member Author

@kevin-bates This is how the conda kernels look like now:
image

And good catch @ptitzler , will add Kevin's suggestion for that case.

@lresende lresende added this to the 2.0.0 milestone Jan 22, 2021
@lresende lresende merged commit 60eb448 into elyra-ai:master Jan 23, 2021
@karlaspuldaro karlaspuldaro deleted the kernel-selection branch March 31, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use kernel display name on python editor toolbar
4 participants