Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename application package to services #1231

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Conversation

ajbozarth
Copy link
Member

@ajbozarth ajbozarth commented Jan 22, 2021

The current application package would be better described as a services package. As such a simple rename from application to services would clarify it's purpose to developers and prevent future misunderstanding of what code belongs there.

Fixes #1231

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ajbozarth ajbozarth requested a review from lresende January 22, 2021 22:58
@ajbozarth ajbozarth self-assigned this Jan 22, 2021
@elyra-bot
Copy link

elyra-bot bot commented Jan 22, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ajbozarth
Copy link
Member Author

Note: I have yet to throughly test this, I have only confirmed it builds and runs the extensions.

@lresende lresende added this to the 2.0.0 milestone Jan 23, 2021
@lresende lresende merged commit 36f9061 into elyra-ai:master Jan 23, 2021
@ajbozarth ajbozarth deleted the services branch February 9, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants