Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running pipelines on Argo and Tekton #1239

Merged
merged 9 commits into from
Jan 27, 2021

Conversation

lresende
Copy link
Member

@lresende lresende commented Jan 26, 2021

Red Hat ODH release 1.0 will be using Kubeflow Pipelines
with Tekton support, so we are enabling Elyra to compile
pipelines for both Argo (default) or Tekton based on
runtime configuration.

Fixes #1222

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende added this to the 2.0.0 milestone Jan 26, 2021
@elyra-bot
Copy link

elyra-bot bot commented Jan 26, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende changed the title [WIP] Add support for running pipelines on Argo and Tekton Add support for running pipelines on Argo and Tekton Jan 26, 2021
@lresende
Copy link
Member Author

KFP servers based on Argo and Tekton are now accepting and running the pipelines, but Tekton deployment is having issues displaying the results due to some metrics related issues (FYI @ptitzler)

@lresende
Copy link
Member Author

On Argo:
image

On Tekton:
image

@lresende lresende removed the request for review from ajbozarth January 26, 2021 22:01
# Compile the new pipeline
try:
pipeline_function = lambda: self._cc_pipeline(pipeline, pipeline_name) # nopep8 E731
kfp.compiler.Compiler().compile(pipeline_function, pipeline_path)
if ('Argo' == engine):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a way this is perhaps not consistent with schema's default, which is Argo. If, for whatever reason, the runtime configuration does contain an invalid value XYZ, the logic would run the Tekton compiler.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other values should not really come in as the metadata is validated and invalid ones will not be shown in the user interface....

@ptitzler
Copy link
Member

It appears that export does not yet take into account the engine type if Python DSL is generated. The Jinja template https://github.com/elyra-ai/elyra/blob/master/elyra/templates/kfp_template.jinja2#L43 always uses the Argo compiler (unless there is some other PR that contains additional changes.

@lresende
Copy link
Member Author

The export has already been updated by @akchinSTC

@ptitzler
Copy link
Member

lresende and others added 7 commits January 26, 2021 16:15
Red Hat ODH release 1.0 will be using Kubeflow Pipelines
with Tekton support, so we are enabling Elyra to compile
pipelines for both Argo (default) or Tekton based on
runtime configuration.
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with this up to the doc changes

@ptitzler
Copy link
Member

The doc update looks good. I also ran a couple tests without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation of Elyra-Pipelines to Tekton based Kubeflow fails
4 participants