Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly propagate runtime when submitting notebook #1306

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

lresende
Copy link
Member

Fixes #1300

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende added this to the 2.1.0 milestone Feb 18, 2021
@elyra-bot
Copy link

elyra-bot bot commented Feb 18, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende
Copy link
Member Author

One thing that we might need to discuss is the name mismatches between the frontend and backend.

We introduced runtime platform on the UI while all the other places are considering it runtime. Should we use runtime throughout the code?

@karlaspuldaro
Copy link
Member

I was able to successfully run it on airflow, but not on kfp, this is the error I get:

Error making request
Error compiling pipeline hello-world-0218163946 for engine None at /var/folders/gz/byw9z3gn1wvddrp1_gt6cg140000gn/T/tmp8k8wzae2/hello-world-0218163946.tar.gz

Even after selecting a pipeline engine on my kfp runtime config, I still get the same type of error.

@ptitzler
Copy link
Member

I was able to successfully run it on airflow, but not on kfp, this is the error I get:

Error making request
Error compiling pipeline hello-world-0218163946 for engine None at /var/folders/gz/byw9z3gn1wvddrp1_gt6cg140000gn/T/tmp8k8wzae2/hello-world-0218163946.tar.gz

Even after selecting a pipeline engine on my kfp runtime config, I still get the same type of error.

What's in the console log?

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for both runtimes without any issues in my environment.

@lresende lresende merged commit bdaa33e into elyra-ai:master Feb 18, 2021
@lresende lresende deleted the fix-submit-notebook branch February 18, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit notebook as pipeline fails
3 participants