-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dark mode for metadata UI #1369
Conversation
This is a follow up to elyra-ai#1327 fixing various bugs as well as adding dark mode support. Dark Mode support for material-ui has now been abstracted to a new ui-component and MetadataEditor has been updated to use it.
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Note those those I tagged for review, this PR touches a lot of code from #1293 if you could make sure I haven't broken anything from that PR (I spent all afternoon making sure I didn't but odd are I missed something) |
For reasons I am still unsure of, this PR makes the code editor in the MetadataEditor (used by code snippets) not load. This is (obviously) causing the tests to fail. I will look into why this is happening tomorrow |
I have made some changes to match @bourdakos1 comments above but I was dealing with rendering race conditions all afternoon. @bourdakos1 I'll ping you tomorrow and see if we can hop on a Webex and you can help me try to figure it out. If I cant figure it out by early afternoon (pacific time) I’m going to partially roll back my work so that the part of the PR that fixes dark mode for the drop down can at least be merged since that part already works fine. That will unblock the 2.1 release, and then we can deal with moving the MetadataEditor to use the JpThemeProvider component in a follow up PR since that’s where the race condition is happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
@lresende once tests pass this should be good to merge (unless you want more reviews first) |
This is a follow up to #1327 fixing various bugs as well as adding
dark mode support.
Dark Mode support for material-ui has now been abstracted to a new
ui-component and MetadataEditor has been updated to use it.
Developer's Certificate of Origin 1.1