-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add offical logos for Python and R #1452
Conversation
Currently we use the jupyterlab python logo, but with the addition of R support we would like to have pipelines use the the offical logos for each node instead of ones designed for the lab file browser Fixes elyra-ai#1445
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Leaving this WIP for a few reasons
Places to change the python logo and whether I've changed them:
|
I think we should leave the For the I personally think the icon in this PR is awkwardly too close to the other launcher icons, but not close enough so it draws your eye in a bad way. If we don't use something closer to the pngs, then I think we should go back to using the icon from |
I've pushed a few updates:
|
The related lab PR jupyterlab/jupyterlab#9958 is now available on |
It may be worth including updating the icon as a pipeline version update |
Currently we use the jupyterlab python logo, but with the addition
of R support we would like to have pipelines use the the offical
logos for each node instead of ones designed for the lab file browser
Fixes #1445
Developer's Certificate of Origin 1.1