Skip to content

Fix React build warnings#1667

Merged
lresende merged 1 commit intoelyra-ai:masterfrom
karlaspuldaro:ci-warnings
May 13, 2021
Merged

Fix React build warnings#1667
lresende merged 1 commit intoelyra-ai:masterfrom
karlaspuldaro:ci-warnings

Conversation

@karlaspuldaro
Copy link
Member

Fixes #1656

What changes were proposed in this pull request?

Add missing dependencies to useCallback array

How was this pull request tested?

Run build with make install no longer displays the warnings

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented May 12, 2021

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende merged commit 62e1964 into elyra-ai:master May 13, 2021
@lresende lresende added this to the 2.3.0.beta2 milestone May 13, 2021
@karlaspuldaro karlaspuldaro deleted the ci-warnings branch August 9, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple react/javascript warnings on CI build

3 participants