Replace 'any' with correct types in typescript code#3279
Merged
lresende merged 1 commit intoelyra-ai:mainfrom Jan 15, 2025
Merged
Replace 'any' with correct types in typescript code#3279lresende merged 1 commit intoelyra-ai:mainfrom
lresende merged 1 commit intoelyra-ai:mainfrom
Conversation
* Replace 'any' with correct types in typescript code * Replace 'any' with correct types in typescript code (complex cases) * Fix tags not being shown * Add missing packageManager prop to install.json file Signed-off-by: Guilherme Caponetto <638737+caponetto@users.noreply.github.com>
lresende
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cherry-picked from ODH Elyra
While migrating the extensions to JupyterLab v4, we faced issues related to type incompatibility after library upgrades. Many of these issues were identified only at runtime due to the extensive usage of
anythroughout the code instead of the correct types. So, this PR reviews the usage ofanyand makes appropriate changes to avoid it as much as possible. Also, the build now throws an error ifanyis used without a reason. Given the structure of the code that has been built on top ofany, the changes on this PR are not perfect, but, hopefully, they will provide more protection to the code on future fixes, upgrades, and new features.How was this pull request tested?
Through CI runs and manual tests.
Developer's Certificate of Origin 1.1