Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog when reloading metadata editor with unsaved changes #853

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

marthacryan
Copy link
Member

@marthacryan marthacryan commented Aug 12, 2020

Fixes #727. Opens this dialog when there are unsaved changes in the metadata editor and the user tries to reload:
image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@marthacryan marthacryan added kind:enhancement New feature or request component:metadata-editor Metadata Editor Extension labels Aug 12, 2020
Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally

@lresende lresende merged this pull request into elyra-ai:master Aug 14, 2020
@marthacryan marthacryan deleted the close-warning branch August 14, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:metadata-editor Metadata Editor Extension kind:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata editor doesn't warn user before reloading page with unsaved changes
4 participants