Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for notebook existence #860

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

marthacryan
Copy link
Member

Fixes #815. Displays this error when the notebook corresponding to a node does not exist.
image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@marthacryan marthacryan added the component:pipeline-editor pipeline editor label Aug 13, 2020
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one quick comment about scalability, I haven't had time to check this out and test it yet though

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments, one on how this related to #861 and another on scalability of the error string. Otherwise the code looks good.

I've also check it out and ran it locally and it works good. Tested it on open, run, export, and when updating properties after moving the notebook to another dir. I also checked that it works right if the notebook is moved back.

validateProperties(node: any): string {
async validateProperties(node: any): Promise<string> {
const notebookValidationErr = await this.app.serviceManager.contents
.get(node.app_data.filename)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick parallel dev note here:

If #861 is merged first then this will need to be updated from node.app_data.filename to PipelineService.getWorkspaceRelativeNodePath(this.widgetContext.path, node.app_data.filename);

If this is merged first then it will need to be added to #861 prior to it's merge

@marthacryan marthacryan requested a review from ajbozarth August 14, 2020 15:49
Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if this gets merged if you could make sure to make a review comment on #861 to update it

@lresende lresende merged this pull request into elyra-ai:master Aug 15, 2020
@marthacryan marthacryan deleted the validate-notebook branch August 17, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline validation should include a check that notebook file exists
4 participants