Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a source distribution of Elyra when creating a release #876

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

akchinSTC
Copy link
Member

@akchinSTC akchinSTC commented Aug 18, 2020

Conda-forge packages require a source distribution to be used instead
of a wheel. This will need to be published alongside the wheel in Pypi

We will need to retroactively(if possible) publish a source dist of elyra for 1.0.0 using the tagged release into pypi to get the conda forge package going, or wait until the next 1.x.x release.

Conda-forge packages require a source distribution to be used instead
of a wheel. This will need to be published alongside the wheel in Pypi
@akchinSTC akchinSTC requested a review from lresende August 18, 2020 23:29
@lresende
Copy link
Member

@akchinSTC have you actually tried to "install from source package" in a clean environment? Does that work?

@akchinSTC
Copy link
Member Author

@lresende - it works. used a clean conda env with python 3.7. Uses still need to run jupyter lab build but thats the same install flow as with our wheel.

@lresende lresende merged commit 6ca0daa into elyra-ai:master Aug 19, 2020
@lresende
Copy link
Member

Also published a 1.0.1 release with both wheel and source tar.

@lresende lresende added this to the 1.0.1 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants