-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable file browser for dependencies in pipeline node properties #881
Conversation
Add support for selecting file dependencies using using a file browser from the node properties in the Pipeline Editor. Fixes elyra-ai#873
thanks, i have resolved the button alignment. as far as the folder icon, that is the link back to JupyterLab's working directory. if a notebook is within a subdirectory then my understanding is the user should not be allowed to navigate to JupyterLab's working directory (hence the reason i hid it). in any case, i have updated the PR and took a different approach. rather hide/remove the directories, the directories are just disabled and not allowed to be clicked and traversed into: not sure which approach is preferred so feedback is welcomed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few clarifying questions, but nothing blocking. Overall this works great and looks good
@@ -506,9 +506,12 @@ export class PipelineEditor extends React.Component< | |||
} | |||
|
|||
propertiesActionHandler(id: string, appData: any, data: any): void { | |||
const propertyId = { name: data.parameter_ref }; | |||
const filename = this.propertiesController.getPropertyValue('filename'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once #861 is merged this will need to be updated to
const filename = this.propertiesController.getPropertyValue('filename'); | |
const filename = PipelineService.getWorkspaceRelativeNodePath( | |
this.widgetContext.path, | |
this.propertiesController.getPropertyValue('filename') | |
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the caveat of the required fix if #861 gets merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried locally and LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried locally with the update to support relative paths and it still LGTM
This PR add support for selecting file dependencies using using a
BrowseFileDialog
from the Properties dialog of the Pipeline Editor.Fixes #873
Developer's Certificate of Origin 1.1