Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default runtime images #908

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

lresende
Copy link
Member

@lresende lresende commented Sep 3, 2020

  • Anaconda (2020.07) with Python 3.x
  • Pandas 1.1.1
  • Tensorflow 2.3.0

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

- Anaconda (2020.07) with Python 3.x
- Pandas 1.1.1
- Pytorch 1.6
- Tensorflow 2.3.0
@lresende lresende added component:build build and build related issues(dependencies and docker) component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines labels Sep 3, 2020
@kevin-bates
Copy link
Member

Image validation is failing:

Checking pytorch/pytorch:1.6-cuda10.1-cudnn7-devel in etc/config/metadata/runtime-images/pytorch-devel.json for curl...
Image pytorch/pytorch:1.6-cuda10.1-cudnn7-devel is not present, pulling...
ERROR: Image pytorch/pytorch:1.6-cuda10.1-cudnn7-devel did not meet criteria for command: curl
Checking pytorch/pytorch:1.6-cuda10.1-cudnn7-devel in etc/config/metadata/runtime-images/pytorch-devel.json for python3...
Image pytorch/pytorch:1.6-cuda10.1-cudnn7-devel is not present, pulling...
ERROR: Image pytorch/pytorch:1.6-cuda10.1-cudnn7-devel did not meet criteria for command: python3

@kevin-bates
Copy link
Member

Are you sure the images names for pytorch/pytorch:1.6-cuda10.1-cudnn7-{devel,runtime} are correct? I'm not able to pull these manually - that's why the build is failing. It fails fast, so it never attempted the 'runtime' image.

@kevin-bates
Copy link
Member

The names are pytorch/pytorch:1.6.0-cuda10.1-cudnn7-runtime and pytorch/pytorch:1.6.0-cuda10.1-cudnn7-devel: https://hub.docker.com/r/pytorch/pytorch/tags

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. Sorry the pytorch update couldn't happen. I did check that it has python, but not curl.

@lresende lresende merged commit eef8c30 into elyra-ai:master Sep 4, 2020
@lresende lresende deleted the update-docker-images branch September 4, 2020 00:27
@lresende lresende added this to the 1.2.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:build build and build related issues(dependencies and docker) component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants