-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common format for pipeline process logging #950
Merged
lresende
merged 7 commits into
elyra-ai:master
from
kevin-bates:improve-pipeline-logging
Oct 13, 2020
Merged
Add common format for pipeline process logging #950
lresende
merged 7 commits into
elyra-ai:master
from
kevin-bates:improve-pipeline-logging
Oct 13, 2020
+110
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trimming the preamble, these log entries look as follows:
|
lresende
approved these changes
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses a base class method
log_pipeline_info()
to issue consistently formatted log messages that can be used to help diagnose where bottlenecks may be occurring or help identify other issues as pipelines are being submitted and processed.A similar pull request will be submitted for kfp-notebook, although the two changes are independent of each other.
A couple of bugs were fixed regarding the conversion of env_vars to a dictionary that this pull request includes since they were preventing local-mode from completing.
Fixes #939
Here is the output from a KFP pipeline submission and export, as well as a Local pipeline run:
KFP Submission:
KFP Export:
Local Run:
Developer's Certificate of Origin 1.1