-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Binder build config (option 1) #963
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
Only caveat is that a user can navigate to the parent folder using the File Browser, which exposes the Elyra source code. This won't do any harm though. The only way to avoid this would be to restructure the content of the home directory as part of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. I just had some comments regarding how others looking at this file in the future would know what these changes are about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent - thank you Patrick. There's a minor typo, but I approve these changes.
Co-authored-by: Kevin Bates <kbates4@gmail.com>
Fixed and thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the Binder build file removing git related directories to hide the fact that the work directory itself is a cloned git repository. See #962 for details and other approaches that didn't seem to yield the desired result.
Closes #962
Developer's Certificate of Origin 1.1