Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Binder build config (option 1) #963

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Update Binder build config (option 1) #963

merged 3 commits into from
Oct 16, 2020

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Oct 6, 2020

This PR updates the Binder build file removing git related directories to hide the fact that the work directory itself is a cloned git repository. See #962 for details and other approaches that didn't seem to yield the desired result.

Closes #962

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Oct 6, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler
Copy link
Member Author

ptitzler commented Oct 6, 2020

Only caveat is that a user can navigate to the parent folder using the File Browser, which exposes the Elyra source code. This won't do any harm though. The only way to avoid this would be to restructure the content of the home directory as part of the postBuild, which I'd rather not do.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. I just had some comments regarding how others looking at this file in the future would know what these changes are about.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thank you Patrick. There's a minor typo, but I approve these changes.

Co-authored-by: Kevin Bates <kbates4@gmail.com>
@ptitzler
Copy link
Member Author

Excellent - thank you Patrick. There's a minor typo, but I approve these changes.

Fixed and thank you!

@ptitzler
Copy link
Member Author

@lresende?

Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lresende lresende merged commit b961de5 into elyra-ai:master Oct 16, 2020
@ptitzler ptitzler deleted the i962-option-2 branch November 20, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binder: cannot use git extension (as intended) because the root directory is already a git repository
4 participants