Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exported file location to response dialog #967

Conversation

lresende
Copy link
Member

@lresende lresende commented Oct 9, 2020

Fixes #872

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@elyra-bot
Copy link

elyra-bot bot commented Oct 9, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende requested a review from kevin-bates October 9, 2020 06:08
@lresende
Copy link
Member Author

lresende commented Oct 9, 2020

image

@lresende lresende added this to the 1.3.0 milestone Oct 9, 2020
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you. Here's a screenshot of the result:
image

@lresende lresende merged commit 69ba697 into elyra-ai:master Oct 9, 2020
@lresende lresende deleted the pipeline-export-add-exported-file-location branch October 9, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Successful pipeline exports should convey where the output can be found
2 participants