Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help icon to launcher #968

Merged
merged 2 commits into from
Oct 10, 2020

Conversation

lresende
Copy link
Member

@lresende lresende commented Oct 9, 2020

Fixes #924

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende requested review from ptitzler and ajbozarth October 9, 2020 06:52
@elyra-bot
Copy link

elyra-bot bot commented Oct 9, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Oct 9, 2020
@lresende
Copy link
Member Author

lresende commented Oct 9, 2020

image

@lresende
Copy link
Member Author

lresende commented Oct 9, 2020

@ptitzler are we ok for the icon? Also, are we ok on opening the help page on another browser tab?

@ptitzler
Copy link
Member

ptitzler commented Oct 9, 2020

Yes, I like it! Perhaps use "Open documentation" as the label?

@lresende lresende force-pushed the add-help-icon-to-launcher branch from d1f9d38 to 4fb7cea Compare October 9, 2020 17:42
@lresende lresende marked this pull request as ready for review October 9, 2020 17:42
@lresende
Copy link
Member Author

lresende commented Oct 9, 2020

image

@lresende lresende removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Oct 9, 2020
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. works fine

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall solid PR, one question on the doc link used, and the icon needed some work. I'll be pushing an update to the icon and a new screenshot right after this.

@ajbozarth
Copy link
Member

updated icon to support dark mode
Screen Shot 2020-10-09 at 2 02 10 PM
Screen Shot 2020-10-09 at 2 02 17 PM

@lresende
Copy link
Member Author

lresende commented Oct 9, 2020

Thanks for the support for dark mode @ajbozarth

@lresende lresende added this to the 1.3.0 milestone Oct 9, 2020
@lresende lresende merged commit 2046964 into elyra-ai:master Oct 10, 2020
@lresende lresende deleted the add-help-icon-to-launcher branch October 10, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to the elyra documentation to the JupyterLab UI
3 participants