-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add help icon to launcher #968
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
@ptitzler are we ok for the icon? Also, are we ok on opening the help page on another browser tab? |
Yes, I like it! Perhaps use "Open documentation" as the label? |
d1f9d38
to
4fb7cea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall solid PR, one question on the doc link used, and the icon needed some work. I'll be pushing an update to the icon and a new screenshot right after this.
Thanks for the support for dark mode @ajbozarth |
Fixes #924
Developer's Certificate of Origin 1.1