Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort list of runtime images retrieved from service #982

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

lresende
Copy link
Member

Fixes #959

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@lresende lresende added this to the 1.3.0 milestone Oct 20, 2020
@lresende lresende requested a review from marthacryan October 20, 2020 16:52
@elyra-bot
Copy link

elyra-bot bot commented Oct 20, 2020

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@lresende lresende force-pushed the sort-runtime-images branch from 194bda2 to 26ff28e Compare October 20, 2020 20:56
let runtimeImages = await FrontendServices.getMetadata('runtime-images');

runtimeImages = runtimeImages.sort(
(a: any, b: any) => 0 - (a.name > b.name ? -1 : 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the 0 -? why not just swap the 1 and -1 in the ternary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lresende lresende merged commit f8ba4a5 into elyra-ai:master Oct 21, 2020
@lresende lresende deleted the sort-runtime-images branch October 21, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata backend: Enable displaying metadata results sorted
2 participants