Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Add missing updating option translation logic #1123

Conversation

derpdead
Copy link
Contributor

Description

Issue #1113

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Tests
  • e2e Test

Checklist:

  • I have read the contribution requirements and fulfil them.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@derpdead derpdead added the bug (type) Something isn't working label Nov 12, 2021
@derpdead derpdead requested a review from bleto November 12, 2021 12:18
@derpdead derpdead self-assigned this Nov 12, 2021
@derpdead derpdead merged commit f54d9b0 into ergonode:feature/attribute-option-sorting Nov 15, 2021
@derpdead derpdead deleted the add-updating-option-translation branch November 15, 2021 07:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug (type) Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants