Documentation, Typing and Refactors #431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changeset
Definition
from acollections.namedtuple
to adataclass
ann_benchmarks.definitions.create_definitions_from_algorithm
by decomposing into separate functions.ann_benchmarks/main.py
by moving filter functions (e.g.filter_disabled_algorithms
) to separate python functions.Motivation
I started working on specific changes to ann-benchmarks (e.g. adding new ANN algorithms, extending ann-benchmarks to be used as a performance testing library), and found the codebase hard to understand as a new user. This PR attempts to make the codebase easier to understand and well documented.