Disable a few algos #472
Merged
Disable a few algos #472
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGT includes QG, ONNG, and PANNG. QG is a quantization and graph-based method. ONNG and PANNG are graph-based methods. Moreover, ONNG and PANNG use different methods of graph construction. If one of these should be disabled, PANNG should be disabled instead of ONNG since PANNG is worse than the others. |
|
@erikbern why are we disabling Qdrant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are algos that are either chronically bad or dominated by some other flavor within the same family
Sad to see you go, Annoy, but the time has come