Idling resource #66
Merged
Idling resource #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Ali-Rezaei |
|
Hi, To make it works again I had to come back to the commit: Unfortunately now i can not help you to fix it, but if is still unsolved, in the weekend I will try to help you. |
|
Hi,
Thank you for your catch. A fix has been pushed to be merged.
Have a nice weekend,
Ali
…On Fri, Jun 1, 2018, 14:33 alexd10s ***@***.***> wrote:
Hi,
I was testing the app in local and I have just noticed that this new
commit is crashing when the User wants to display the favorites movies, but
have not selected any movie as favorite before.
To make it works again I had to come back to the commit:
fc21d51
<fc21d51>
Unfortunately now i can not help you to fix it, but if is still unsolved,
in the weekend I will try to help you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWfFw5kBHCpxBkQp6GhTK9lLqBTRHIJks5t4RGCgaJpZM4TejYF>
.
|
|
@Ali-Rezaei @AlexD10S merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idlingResource for Espresso test