ethclient: add NetworkID function #14791
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested changes
Jul 31, 2017
ethclient/ethclient.go
Outdated
|
|
||
| version.SetString(ver, 10) | ||
| return | ||
| } |
There was a problem hiding this comment.
Please remove return value names.
Please parse into version directly instead of doing the parsing via SetString.
version := new(big.Int)
err := ec.c.CallContext(ctx, &version, "net_version")
return version, errThere was a problem hiding this comment.
I'll remove the return value names.
Regarding the direct parsing: the result is returned from the RPC interface as a string rather than a number:
{"jsonrpc":"2.0","id":74,"result":"1"}
so attempting to unmarshal directly in to the big.Int fails. Is this an underlying issue with the RPC interface or should I leave the string parsing code in place?
There was a problem hiding this comment.
I looked at the spec a bit too quickly and mistook "id" for "result". The string parsing is fine then, but please check for errors when parsing the string.
markya0616
pushed a commit
to markya0616/go-ethereum
that referenced
this pull request
Aug 17, 2017
There is currently no simple way to obtain the network ID from a Client. This adds a NetworkID method that wraps the net_version JSON-RPC call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no simple way to obtain the network ID from a Client. This adds a NetworkID() function that wraps the net_version JSON-RPC call and returns the network ID in a suitable format.