Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eof: Test that EOF sets the experimental flag in metadata #15663

Merged
merged 1 commit into from
Jan 30, 2025
Merged

eof: Test that EOF sets the experimental flag in metadata #15663

merged 1 commit into from
Jan 30, 2025

Conversation

rodiazet
Copy link
Contributor

Add test which checks that setting an EOF version results in the experimental flag being set.

@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@rodiazet rodiazet mentioned this pull request Dec 19, 2024
Merged
cameel
cameel reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make the test use settings from command-line like other metadata tests already do. Other than that the test seems ok.

@cameel cameel changed the title eof: Add test of eof compiler flag eof: Test that EOF sets the experimental flag in metadata Dec 19, 2024
@cameel
Copy link
Member

cameel commented Jan 29, 2025

This one needs rebase. And only small adjustments so we we should be able to merge it easily.

@rodiazet rodiazet force-pushed the eof-flag-set-test branch 3 times, most recently from 5cc7d85 to e8e2e43 Compare January 29, 2025 13:54
cameel
cameel previously approved these changes Jan 29, 2025
View reviewed changes
@cameel cameel merged commit 77488fa into ethereum:develop Jan 30, 2025
73 of 74 checks passed
@cameel cameel mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameel cameel

Assignees
No one assigned
Labels
EOF external contribution ⭐ testing 🔨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rodiazet @cameel