Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct code comments and references in ArrayUtils, CHC, EncodingContext, and LSP tests #15801

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

Pistasha
Copy link
Contributor

Summary

This PR updates several minor code comments and references for clarity and correctness:

  • ArrayUtils.cpp: Corrected the comment to accurately reflect the "Compute 2^length + 1" operation.
  • CHC.cpp: Adjusted the solverStackHeight() condition to ensure proper logic.
  • EncodingContext.h: Fixed the function signature and naming for better clarity.
  • goto_definition_imports.sol: Updated import cursor references (@weatherImportCursor) and related comments.

How did you test your changes?

  • Verified that the code compiles successfully.
  • Ran existing test suites to ensure no regressions.
  • Manually reviewed each changed comment/import for correctness.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@cameel cameel enabled auto-merge (squash) January 31, 2025 14:12
@cameel cameel merged commit 85074cc into ethereum:develop Jan 31, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants