Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including directory name into the stack trace for some files #11519

Closed
gaearon opened this issue Nov 10, 2017 · 3 comments · Fixed by #12059
Closed

Consider including directory name into the stack trace for some files #11519

gaearon opened this issue Nov 10, 2017 · 3 comments · Fixed by #12059

Comments

@gaearon
Copy link
Collaborator

gaearon commented Nov 10, 2017

See https://twitter.com/deadcoder0904/status/929050109425229824

Maybe if the file is called index.js (pretty common with some directory structures) we should include the directory name into the short component stack trace.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2017

Not sure how well that would work but I'd love to see an example. You'll need to change describeComponentFrame() if I recall correctly.

@xjlim
Copy link
Contributor

xjlim commented Nov 10, 2017

@gaearon I'd like to work on this.

@gaearon
Copy link
Collaborator Author

gaearon commented Nov 10, 2017

Sounds good, it's yours!

@aweary aweary changed the title Consider including directory name into the stack trace for some fikes Consider including directory name into the stack trace for some files Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants