Fix forceUpdate in shallow test renderer #11239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Oct 17, 2017
| @@ -188,6 +190,7 @@ class Updater { | |||
| } | |||
|
|
|||
| enqueueForceUpdate(publicInstance, callback, callerName) { | |||
| this._renderer._forcedUpdate = true; | |||
There was a problem hiding this comment.
Since you're adding a new field can you also initialize it in the constructor please?
|
I think this looks good. Thanks. |
This was referenced Nov 9, 2017
Update react in packages/oc-template-react from 16.0.0 to 16.1.0
opencomponents/oc-template-react#48
Closed
This was referenced Feb 2, 2018
Open
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11236 by adding a flag during
enqueueForceUpdateto make sure theshouldComponentUpdateis not being tested against.