Warn for update on different component in render #17099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: a8c6a1b...bd8fbdb react-art
react-dom
react-test-renderer
react-reconciler
react-native-renderer
|
6b0ffdf
to
bd8fbdb
Compare
Jessidhia
reviewed
Oct 24, 2019
| 'Cannot update during an existing state transition (such as ' + | ||
| 'within `render`). Render methods should be a pure function of ' + | ||
| 'props and state.', | ||
| ); |
There was a problem hiding this comment.
Why use warningWithoutStack instead of warning here?
| @@ -491,6 +491,50 @@ describe('ReactHooksWithNoopRenderer', () => { | |||
| ]); | |||
| expect(ReactNoop.getChildren()).toEqual([span(22)]); | |||
| }); | |||
|
|
|||
| it('warns about render phase update on a different component', async () => { | |||
There was a problem hiding this comment.
I presume there's already a test for it not warning if it's the same component?
|
@sebmarkbage @gaearon Do we want to land this warning? If so I'll update it |
ermanzohre
approved these changes
Feb 19, 2020
|
@ermanzohre Can I ask you to please not “approve” old pull requests? Your actions are creating notification noise for everyone watching the repo. Thanks. |
trueadm
approved these changes
Feb 19, 2020
This warning already exists for class components, but not for functions. It does not apply to render phase updates to the same component, which have special semantics that we do support.
bd8fbdb
to
1051db9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Details of bundled changes.Comparing: 085d021...1051db9 react-dom
react-art
react-test-renderer
react-native-renderer
react-reconciler
Size changes (experimental) |
Details of bundled changes.Comparing: 085d021...1051db9 react-dom
react-native-renderer
react-reconciler
react-art
react-test-renderer
Size changes (stable) |
sebmarkbage
reviewed
Feb 25, 2020
| switch (fiber.tag) { | ||
| case FunctionComponent: | ||
| case ForwardRef: | ||
| case SimpleMemoComponent: { |
There was a problem hiding this comment.
I guess this should include Block too?
Merged
This was referenced Mar 6, 2020
This was referenced Sep 25, 2024
This was referenced Sep 28, 2024
This was referenced Sep 29, 2024
This was referenced Oct 4, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 25, 2024
This was referenced Oct 26, 2024
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning already exists for class components, but not for functions.
It does not apply to render phase updates to the same component, which have special semantics that we do support.