fix(eslint-plugin-react-hooks): accepting as expressions as deps array

[StyleShit]

Summary

This PR closes #25844
The original issue talks about as const, but seems like it fails for any as X expressions since it adds another nesting level to the AST.

EDIT: Also closes #20162

How did you test this change?

Added unit tests

[facebook-github-bot]

Hi @StyleShit!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[react-sizebot]

Comparing: 53b12e4...aa068d1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.37%	92.14 kB	92.49 kB	+0.35%	21.70 kB	21.77 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.37%	92.14 kB	92.49 kB	+0.35%	21.70 kB	21.77 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.js	+0.37%	92.29 kB	92.63 kB	+0.35%	21.72 kB	21.80 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.36%	93.13 kB	93.46 kB	+0.24%	21.92 kB	21.97 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.36%	93.13 kB	93.46 kB	+0.24%	21.92 kB	21.97 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js	+0.36%	93.27 kB	93.61 kB	+0.24%	21.94 kB	21.99 kB
oss-stable-semver/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js	+0.33%	27.00 kB	27.08 kB	+0.21%	9.30 kB	9.32 kB
oss-stable/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js	+0.33%	27.00 kB	27.08 kB	+0.21%	9.30 kB	9.32 kB
oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.production.min.js	+0.32%	27.59 kB	27.68 kB	+0.30%	9.47 kB	9.50 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against aa068d1

[eps1lon]

Makes sense, thank you. Can you sign the CLA so that we can merge this? It may take a while between signing and the status to become green.

[StyleShit]

Already signed when opening the PR, just waiting for it to update 😄

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!