Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Override the getCurrentStack temporarily while printing errors #30300

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[Fiber] Override the getCurrentStack temporarily while printing errors #30300

merged 1 commit into from
Jul 10, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Only for parent stacks. This ensures that we can use the regular mechanism for appending stack traces. E.g. you can polyfill it.

This is mainly so that I can later remove the automatic appending.

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:02pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 9, 2024
@sebmarkbage
Override the getCurrentStack temporarily while printing errors
69683c5 
Only for parent stacks. This ensures that we can use the regular mechanism
for appending stack traces.
@sebmarkbage sebmarkbage merged commit 3b2e5f2 into facebook:main Jul 10, 2024
139 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@sebmarkbage
[Fiber] Override the getCurrentStack temporarily while printing errors (
517d6b2 
#30300)

Only for parent stacks. This ensures that we can use the regular
mechanism for appending stack traces. E.g. you can polyfill it.

This is mainly so that I can later remove the automatic appending.

DiffTrain build for commit 3b2e5f2.
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@sebmarkbage
[Fiber] Override the getCurrentStack temporarily while printing errors (
6460f04 
#30300)

Only for parent stacks. This ensures that we can use the regular
mechanism for appending stack traces. E.g. you can polyfill it.

This is mainly so that I can later remove the automatic appending.

DiffTrain build for [3b2e5f2](3b2e5f2)
@sebmarkbage sebmarkbage mentioned this pull request Jul 10, 2024
Merged
sebmarkbage added a commit that referenced this pull request Jul 10, 2024
@sebmarkbage
Override the getCurrentStack temporarily while printing uncaught erro…
29552c7 
…rs (#30309)

This is just a follow up to #30300.

I forgot the uncaught branch.
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@sebmarkbage
Override the getCurrentStack temporarily while printing uncaught erro…
106b53a 
…rs (#30309)

This is just a follow up to #30300.

I forgot the uncaught branch.

DiffTrain build for commit 29552c7.
github-actions bot pushed a commit that referenced this pull request Jul 10, 2024
@sebmarkbage
Override the getCurrentStack temporarily while printing uncaught erro…
5fb5ce8 
…rs (#30309)

This is just a follow up to #30300.

I forgot the uncaught branch.

DiffTrain build for [29552c7](29552c7)
@eps1lon eps1lon mentioned this pull request Jul 16, 2024
Closed
This was referenced Jul 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @eps1lon @facebook-github-bot