Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][fixtures] Repro for fbt + non-ascii strings #30386

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 7:39pm

mofeiZ added a commit that referenced this pull request Jul 18, 2024
ghstack-source-id: 05211980566f8c061ac2ca8ce51e442d234beacc
Pull Request resolved: #30386
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 18, 2024
@mofeiZ mofeiZ marked this pull request as ready for review July 18, 2024 19:20
@react-sizebot
Copy link

react-sizebot commented Jul 18, 2024

Comparing: 512b09b...6d23842

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.80 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 6d23842

@mofeiZ mofeiZ merged commit 6d6a69c into gh/mofeiZ/12/base Jul 18, 2024
24 checks passed
mofeiZ added a commit that referenced this pull request Jul 18, 2024
ghstack-source-id: 05211980566f8c061ac2ca8ce51e442d234beacc
Pull Request resolved: #30386
@mofeiZ mofeiZ deleted the gh/mofeiZ/12/head branch July 18, 2024 20:18
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 05211980566f8c061ac2ca8ce51e442d234beacc
Pull Request resolved: facebook#30386
felixshiftellecon added a commit to felixshiftellecon/react that referenced this pull request Jul 24, 2024
ghstack-source-id: 05211980566f8c061ac2ca8ce51e442d234beacc
Pull Request resolved: facebook#30386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants