Unify RootDidNotComplete and RootSuspendedWithDelay exit path #31547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both now go through finishConcurrentRender (which is not just for concurrent).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sebmarkbage
commented
Nov 15, 2024
| // cases where need to exit the current render without producing a | ||
| // consistent tree or committing. | ||
| const didAttemptEntireTree = !workInProgressRootDidSkipSuspendedSiblings; | ||
| markRootSuspended(root, lanes, NoLane, didAttemptEntireTree); |
There was a problem hiding this comment.
In the else branch we just fall through to finishConcurrentRender since we won't be concurrent and it doesn't match the explicit exitStatus checks.
Therefore we enter the same path as RootSuspendedWithDelay and we can use the same code path.
sebmarkbage
commented
Nov 15, 2024
| didAttemptEntireTree, | ||
| ); | ||
| return; | ||
| if (!includesOnlyTransitions(lanes)) { |
There was a problem hiding this comment.
This is the subtle difference that RootSuspendedWithDelay checks the lanes but maybe we should just do that before setting the flag in the first place?
|
Comparing: 63cde68...8f8b017 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename RootDidNotComplete to RootSuspendedAtTheShell since it specifically means something suspended in the shell during hydration.