Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crud] Rename Effect type #31557

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[crud] Rename Effect type #31557

merged 3 commits into from
Nov 15, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Nov 15, 2024

Adds a new Effect type which for now just points to the SimpleEffect type, in prepartion for later in the stack where we add more.


Stack created with Sapling. Best reviewed with ReviewStack.

Scaffolds the initial `useResourceEffect` dispatcher type. This will eventually be folded into `useEffect` et al as an overload.
Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 10:01pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Nov 15, 2024
Adds a new feature flag for `enableUseResourceEffectHook`.
@react-sizebot
Copy link

react-sizebot commented Nov 15, 2024

Comparing: 0480cdb...c285efb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 509.08 kB 509.08 kB = 91.00 kB 91.00 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 514.01 kB 514.01 kB = 91.71 kB 91.71 kB
facebook-www/ReactDOM-prod.classic.js = 588.65 kB 588.65 kB = 104.18 kB 104.18 kB
facebook-www/ReactDOM-prod.modern.js = 578.91 kB 578.91 kB = 102.59 kB 102.59 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d54c9a8

Adds a new `Effect` type which for now just points to the `SimpleEffect` type, in prepartion for later in the stack where we add more.
poteto added a commit that referenced this pull request Nov 15, 2024
Scaffolds the initial `useResourceEffect` dispatcher type. This will
eventually be folded into `useEffect` et al as an overload.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31555).
* #31523
* #31557
* #31556
* __->__ #31555
poteto added a commit that referenced this pull request Nov 15, 2024
Adds a new feature flag for `enableUseResourceEffectHook`.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31556).
* #31523
* #31557
* __->__ #31556
* #31555
@poteto poteto merged commit 053b3cb into main Nov 15, 2024
184 checks passed
@poteto poteto deleted the pr31557 branch November 15, 2024 22:50
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
Adds a new `Effect` type which for now just points to the `SimpleEffect`
type, in prepartion for later in the stack where we add more.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31557).
* #31523
* __->__ #31557
* #31556
* #31555

DiffTrain build for [053b3cb](053b3cb)
github-actions bot pushed a commit that referenced this pull request Nov 15, 2024
Adds a new `Effect` type which for now just points to the `SimpleEffect`
type, in prepartion for later in the stack where we add more.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31557).
* #31523
* __->__ #31557
* #31556
* #31555

DiffTrain build for [053b3cb](053b3cb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants