Grammar correction in ReactDOMInput.js warning #6657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakeboone02 You will need to fix the unit tests to match. See https://github.com/facebook/react/pull/6591/files |
|
@jakeboone02 The original author of that PR hasn't responded in a week. If you want to fix the tests in your PR, we could merge this one. Your call. |
| @@ -7966,7 +7966,7 @@ var ReactDOMInput = { | |||
| var owner = inst._currentElement._owner; | |||
|
|
|||
| if ((initialValue || !inst._wrapperState.controlled) && controlled && !didWarnUncontrolledToControlled) { | |||
| "development" !== 'production' ? warning(false, '%s is changing a uncontrolled input of type %s to be controlled. ' + 'Input elements should not switch from uncontrolled to controlled (or vice versa). ' + 'Decide between using a controlled or uncontrolled input ' + 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', owner && owner.getName() || 'A component', props.type) : void 0; | |||
| "development" !== 'production' ? warning(false, '%s is changing an uncontrolled input of type %s to be controlled. ' + 'Input elements should not switch from uncontrolled to controlled (or vice versa). ' + 'Decide between using a controlled or uncontrolled input ' + 'element for the lifetime of the component. More info: https://fb.me/react-controlled-components', owner && owner.getName() || 'A component', props.type) : void 0; | |||
There was a problem hiding this comment.
As per note in other PR, this file is auto-generated and should not be changed. Please update the PR such that this file remains unchanged.
|
Looks good, just same comment as in the other PR. |
|
@jakeboone02 updated the pull request. |
|
OK, working on this. I'll squash to one commit as well. |
Changed "a uncontrolled input" to "an uncontrolled input".
|
@jakeboone02 updated the pull request. |
|
Thanks @jakeboone02! |
zpao
pushed a commit
that referenced
this pull request
May 10, 2016
Changed "a uncontrolled input" to "an uncontrolled input". (cherry picked from commit 393a179)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "a uncontrolled input" to "an uncontrolled input".