Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IE11 placeholder textContent value bug. #7002

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

jimfb
Copy link
Contributor

@jimfb jimfb commented Jun 9, 2016

Fix IE11 placeholder textContent value bug.

Pop quiz: What does IE11 give you if...

var node = document.createElement('textarea');
node.placeholder = 'placeholder';
node.textContent = 'textContent';
assert(typeof node.value === 'string');
alert((typeof node.value)+':'+node.value);

Apparently placeholder detaches value, or something.

In case you're wondering, no, this bug shows up in 15.0.1, so it was not caused by my recent value change. It was something else introduced prior to v15.

Fixes #6984

@jimfb
Copy link
Contributor Author

jimfb commented Jun 9, 2016

cc @spicyj

@sophiebits
Copy link
Collaborator

Does Edge have the same problem?

@jimfb
Copy link
Contributor Author

jimfb commented Jun 9, 2016

@spicyj No, edge does the right thing.

@ghost ghost added the CLA Signed label Jun 9, 2016
@jimfb jimfb merged commit f0b140d into facebook:master Jun 9, 2016
@zpao zpao added this to the 15-next milestone Jun 14, 2016
zpao pushed a commit that referenced this pull request Jun 14, 2016
@zpao zpao modified the milestones: 15-next, 15.2.0 Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants