fix webcomponent example issue #7056 #7057
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| value: function() { | ||
| } | ||
| } | ||
| ,attributeChangedCallback: { |
There was a problem hiding this comment.
Afaik, we don't need to define createdCallback, detachedCallback, nor attributeChangedCallback. It just makes the example more complicated and detracts from what we're demonstrating. Can you remove these additional functions?
There was a problem hiding this comment.
You are correct, they are not required for the purposes of the demonstration, though it is quite nice to have all four callbacks available should someone want to know which ones exist or want to expand upon the example. Also, I didn't see it as complicating the example since they are empty functions but to your point, less code to read is less. I will remove them.
|
Looks good, thanks! |
fixes issue #7056