Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #7170 #7486

Merged
merged 4 commits into from
Aug 15, 2016
Merged

Fix for #7170 #7486

merged 4 commits into from
Aug 15, 2016

Conversation

troydemonbreun
Copy link
Contributor

Fix for #7170

@troydemonbreun
Copy link
Contributor Author

@keyanzhang Will this change invalidate your test "resets value of date/time input to fix bugs in iOS Safari" (and therefore break #7397)?

Thanks for your help.

@ghost ghost added the CLA Signed label Aug 12, 2016
@troydemonbreun
Copy link
Contributor Author

@keyanzhang nevermind, apparently I had some fluke locally - sorry to bother you

@aweary
Copy link
Contributor

aweary commented Aug 12, 2016

@troydemonbreun were you able to test and verify that this actually resolved #7170?

@ghost ghost added the CLA Signed label Aug 12, 2016
@troydemonbreun
Copy link
Contributor Author

@aweary yes

@ghost ghost added the CLA Signed label Aug 15, 2016
@aweary
Copy link
Contributor

aweary commented Aug 15, 2016

I cloned this locally and verified it worked as well, thanks @troydemonbreun!

@aweary aweary merged commit 3013afe into facebook:master Aug 15, 2016
@troydemonbreun troydemonbreun deleted the r-7170 branch August 15, 2016 18:55
@zpao zpao modified the milestones: 15-next, 15.3.1 Aug 15, 2016
zpao pushed a commit that referenced this pull request Aug 15, 2016
@troydemonbreun @zpao
Fix for #7170 (#7486)
bfb3852 
* Write failing test

* Ensure .min and .max are set before .value

* Adjusting test for false negative

* Revert test adjustment (apparently it was only failing locally)

(cherry picked from commit 3013afe)
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
1 task
@rturnq rturnq mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
15.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@troydemonbreun @aweary @zpao @facebook-github-bot