Adding SSR test for form fields. #9264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Mar 27, 2017
sophiebits
reviewed
Mar 30, 2017
| <input value="foo" defaultValue="bar" readOnly={true} />, | ||
| 1, | ||
| ); | ||
| expect(e.value).toBe('foo'); |
There was a problem hiding this comment.
Do you want to check e.getAttribute('value') too?
There was a problem hiding this comment.
Good call. I added those checks in a734aec. Thanks!
| itRenders( | ||
| 'an input with a value and no onChange/readOnly', | ||
| async render => { | ||
| // this configuration should raise a dev warning that value without |
There was a problem hiding this comment.
I suppose it's not clear to me whether we should try to keep all the warnings in sync between the renderers. It seems not-super-valuable if you always revive on the client side, though I suppose if we want to support server-only rendering then we should have all the warnings there too. In any event, this seems good for now.
There was a problem hiding this comment.
I agree; I'm genuinely not certain if it's a good idea to have in SSR or not. If not, we can just change these tests pretty easily, though.
|
Thanks, merged! 🎉🎉🎉 |
|
🎉 :D |
This was referenced Sep 28, 2017
This was referenced Oct 28, 2017
This was referenced Dec 1, 2017
This was referenced Feb 2, 2018
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last (🎉😢) of my planned SSR unit test PRs (following on #9055, #9089, #9106, #9221, and #9257). It tests form fields:
<input type=text>,<input type=checkbox>,<textarea>, and<select>.The first set of tests makes sure that the server renderer correctly maps React properties for each of those fields to correct DOM properties (or for
textarea, to inner text). It also makes sure that the renderer warns when a value is set without onChange or readOnly.The latter tests attempt to make sure that form fields that have been server rendered work correctly with user interaction, whether they are controlled or uncontrolled and whether the user interaction happens before client render or after.
I also deleted a duplicative unrelated test that @spicyj mentioned in a review comment on #9257.
This set of tests are more verbose and a little more complex than some of the others; I welcome any feedback to make them more readable. Thanks!