Skip to content

Comments

[Remote Compaction] Add base_input_level and output_level in CompactionServiceJobInfo#13555

Closed
jaykorean wants to merge 3 commits intofacebook:mainfrom
jaykorean:level_info_in_compaction_service_job_info
Closed

[Remote Compaction] Add base_input_level and output_level in CompactionServiceJobInfo#13555
jaykorean wants to merge 3 commits intofacebook:mainfrom
jaykorean:level_info_in_compaction_service_job_info

Conversation

@jaykorean
Copy link
Contributor

@jaykorean jaykorean commented Apr 17, 2025

Summary

Similar to #13029, add base_input_level (a.k.a. start_level) and output_level to CompactionServiceJobInfo

Test Plan

Updated Unit Tests

./compaction_service_test

@jaykorean jaykorean force-pushed the level_info_in_compaction_service_job_info branch from 2d01408 to 84d40dc Compare April 17, 2025 21:04
@jaykorean jaykorean changed the title [Remote Compaction] Add start_level and output_level in CompactionServiceJobInfo [Remote Compaction] Add base_input_level and output_level in CompactionServiceJobInfo Apr 17, 2025
@jaykorean jaykorean requested a review from anand1976 April 17, 2025 21:11
@jaykorean jaykorean marked this pull request as ready for review April 17, 2025 21:11
@facebook-github-bot
Copy link
Contributor

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jaykorean has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hx235
Copy link
Contributor

hx235 commented Apr 17, 2025

Will the primary ever need to send with remote compaction info about whether the compaction will output to the second to the last level (penultimate level)? If it does, output level may not capture that info just fyi :) @jaykorean

@jaykorean
Copy link
Contributor Author

@hx235

Will the primary ever need to send with remote compaction info about whether the compaction will output to the second to the last level?

IIUC it should be determined by options.preclude_last_level_data_seconds, not the output level. If there was output in the penultimate level or not, is going to be part of compaction stats after compaction is done.

@facebook-github-bot
Copy link
Contributor

@jaykorean has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jaykorean merged this pull request in 9b186c8.

@jaykorean jaykorean deleted the level_info_in_compaction_service_job_info branch April 18, 2025 00:48
ybtsdst pushed a commit to ybtsdst/rocksdb that referenced this pull request Apr 27, 2025
…cebook#13555)

Summary:
Similar to facebook#13029, add `base_input_level` (a.k.a. start_level) and `output_level` to `CompactionServiceJobInfo`

Pull Request resolved: facebook#13555

Test Plan:
Updated Unit Tests
```
./compaction_service_test
```

Reviewed By: anand1976

Differential Revision: D73213504

Pulled By: jaykorean

fbshipit-source-id: abb3b0025bc12245b812ef589fe77e9a30ba0c46
facebook-github-bot pushed a commit that referenced this pull request May 16, 2025
Summary:
Similar to #13555, add more info, ColumnFamily Id and name, to `CompactionServiceJobInfo`.

Pull Request resolved: #13615

Test Plan:
Updated Unit Test
```
./compaction_service_test
```

Reviewed By: archang19

Differential Revision: D74845661

Pulled By: jaykorean

fbshipit-source-id: e2fc61006092b9febec1c6637b92cb00fb6cb73e
SoujanyaPonnapalli pushed a commit to tyler-griggs/rocksdb that referenced this pull request Jul 20, 2025
…cebook#13555)

Summary:
Similar to facebook#13029, add `base_input_level` (a.k.a. start_level) and `output_level` to `CompactionServiceJobInfo`

Pull Request resolved: facebook#13555

Test Plan:
Updated Unit Tests
```
./compaction_service_test
```

Reviewed By: anand1976

Differential Revision: D73213504

Pulled By: jaykorean

fbshipit-source-id: abb3b0025bc12245b812ef589fe77e9a30ba0c46
SoujanyaPonnapalli pushed a commit to tyler-griggs/rocksdb that referenced this pull request Jul 20, 2025
Summary:
Similar to facebook#13555, add more info, ColumnFamily Id and name, to `CompactionServiceJobInfo`.

Pull Request resolved: facebook#13615

Test Plan:
Updated Unit Test
```
./compaction_service_test
```

Reviewed By: archang19

Differential Revision: D74845661

Pulled By: jaykorean

fbshipit-source-id: e2fc61006092b9febec1c6637b92cb00fb6cb73e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants