Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Add unit testing. #1877

Merged
merged 7 commits into from
Mar 31, 2024
Merged

HITL - Add unit testing. #1877

merged 7 commits into from
Mar 31, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Mar 26, 2024 •
edited
Loading

Motivation and Context

This changeset adds unit testing for habitat-hitl.

The following tests are added:

  • main() smoke test.
  • Example apps smoke tests.
  • User mask test.

How Has This Been Tested

Tested locally and on CI.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 26, 2024
@0mdc 0mdc changed the title Add main unit test. HITL - Add unit testing. Mar 26, 2024
@0mdc 0mdc requested review from aclegg3 and jturner65 March 27, 2024 00:19
@0mdc 0mdc marked this pull request as ready for review March 27, 2024 00:19
@0mdc
Copy link
Contributor Author

0mdc commented Mar 27, 2024 •
edited
Loading

This looks stable. However, habitat-lab's test/test_humanoid.py is failing. I'm verifying whether this is somehow related to my changes.

0mdc
0mdc commented Mar 27, 2024
View reviewed changes
Copy link
Contributor Author

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for reviewers.

.circleci/config.yml Outdated Show resolved Hide resolved
test/hitl/test_hitl_examples.py Outdated
"examples/hitl/basic_viewer/basic_viewer.py",
"--config-dir",
"test/config/habitat_hitl",
"+experiment=smoke_test",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uses the Hydra experiment workflow. I'm intending to have more than one in the future.

aclegg3
aclegg3 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests. Small questions on the config changes, but not a blocker if things are working as expected.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@0mdc 0mdc merged commit 3d39b3d into main Mar 31, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/hitl_testing branch March 31, 2024 20:46
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
HITL - Add unit testing. (facebookresearch#1877)
6c8b33b 
* Add main unit test.

* Add user mask test.

* Run HITL tests after lab API tests.

* Isolate hitl tests from habitat-lab.

* Rename test_example to avoid conflict.

* Fix typo in 'Ensure not-editable mode works'

* Address review comments.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
HITL - Add unit testing. (facebookresearch#1877)
316286c 
* Add main unit test.

* Add user mask test.

* Run HITL tests after lab API tests.

* Isolate hitl tests from habitat-lab.

* Rename test_example to avoid conflict.

* Fix typo in 'Ensure not-editable mode works'

* Address review comments.
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
HITL - Add unit testing. (facebookresearch#1877)
6eb0be6 
* Add main unit test.

* Add user mask test.

* Run HITL tests after lab API tests.

* Isolate hitl tests from habitat-lab.

* Rename test_example to avoid conflict.

* Fix typo in 'Ensure not-editable mode works'

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot