Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HITL - Activate mouse look with middle mouse button. Adjust sensitivity. #1902

Merged
merged 1 commit into from
Apr 11, 2024
Merged

HITL - Activate mouse look with middle mouse button. Adjust sensitivity. #1902

merged 1 commit into from
Apr 11, 2024

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Apr 8, 2024

Motivation and Context

This allows to look around when pressing the middle mouse button in first-person mode.
The sensitivity is also toned down.

How Has This Been Tested

Tested locally.

Types of changes

  • [Development]

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@0mdc 0mdc requested review from jturner65 and aclegg3 April 8, 2024 01:27
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 8, 2024
aclegg3
aclegg3 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but remember that some users may not have middle mouse button (e.g. apple magic mouse). I see GuiInput.KeyNS.R as an option also. Is this r key as an alternative?

@0mdc
Copy link
Contributor Author

0mdc commented Apr 11, 2024

Yes, r is an alternative.

@0mdc 0mdc merged commit 237d028 into main Apr 11, 2024
4 checks passed
@0mdc 0mdc deleted the 0mdc/adjust_mouse_look branch April 11, 2024 01:54
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jun 26, 2024
@0mdc @dannymcy
Activate mouse look with middle mouse button. Adjust sensitivity. (fa…
afb865e 
…cebookresearch#1902)
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc
Activate mouse look with middle mouse button. Adjust sensitivity. (fa…
e2202cc 
…cebookresearch#1902)
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@0mdc @dannymcy
Activate mouse look with middle mouse button. Adjust sensitivity. (fa…
5d922a5 
…cebookresearch#1902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot