Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent passing aux/opt vars to optim kwargs in theseus layer forward #42

Closed
mhmukadam opened this issue Dec 22, 2021 · 1 comment · Fixed by #45
Closed

Prevent passing aux/opt vars to optim kwargs in theseus layer forward #42

mhmukadam opened this issue Dec 22, 2021 · 1 comment · Fixed by #45
Assignees
Labels
refactor Refactor library components
Milestone

Comments

@mhmukadam
Copy link
Contributor

From discussion:

layer.forward(input_data={}, optimizer_kwargs={"verbose": True, "track_best_solution": True, "damping": 0.01, ..., etc })
After refactoring this way, I don't think we need to check at the if the keys passed to the dictionary are good or not. In fact, we should probably rename it to optimizer_options={} so it's pretty obvious what this dict is supposed to be doing.

@mhmukadam mhmukadam added the refactor Refactor library components label Dec 22, 2021
@mhmukadam mhmukadam added this to the 0.1.0-b.2 milestone Dec 22, 2021
@mhmukadam
Copy link
Contributor Author

Closes #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor library components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants