Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added batching support to tactile pushing example. #132

Merged
merged 6 commits into from
Mar 29, 2022
Merged

Added batching support to tactile pushing example. #132

merged 6 commits into from
Mar 29, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Mar 24, 2022

@psodhi I added batching support, if you could take a look to double check everything that would be great!

@luisenp luisenp added the enhancement New feature or request label Mar 24, 2022
@luisenp luisenp requested a review from mhmukadam March 24, 2022 20:50
@luisenp luisenp self-assigned this Mar 24, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2022
@luisenp luisenp merged commit 5162a12 into main Mar 29, 2022
@luisenp luisenp deleted the lep.tactile_add_batch branch March 29, 2022 18:07
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Added batching support to tactile pushing example. (facebookresearch#132
29646ad 
)

* Added batching support to tactile pushing example.

* Changed outer loss so that it uses SE2.local().

* Added more options for the inner optimizer.

* Added options to control backward mode and step size.a

* Added results logging.

* Added cfg values for lr and early stopping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisenp @mhmukadam @facebook-github-bot