Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed RobotModel.dim() #156

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Removed RobotModel.dim() #156

merged 1 commit into from
Apr 12, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Apr 12, 2022

It was not currently used for anything important and it's not clear that it will ever be needed.

@luisenp luisenp requested a review from mhmukadam April 12, 2022 18:31
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2022
@luisenp luisenp added refactor Refactor library components and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 12, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 12, 2022
@mhmukadam mhmukadam merged commit 8b11074 into main Apr 12, 2022
@mhmukadam mhmukadam deleted the lep.remove_robot_model_dim branch April 12, 2022 22:42
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. refactor Refactor library components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants