Added a check in TheseusFunction that enforces copy() also copies the variables #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmukadam
reviewed
Jun 3, 2022
mhmukadam
reviewed
Jun 3, 2022
mhmukadam
reviewed
Jun 3, 2022
mhmukadam
approved these changes
Jun 6, 2022
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
… variables (facebookresearch#202) * Added a check in TheseusFunction that enforces copy() also copies the variables. * Added clearer error message for duplicate vars in TheseusFunction.copy(). * Minor fix in unit test import convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using copy to create new variables in the cost function vectorization code, and this would help avoid some unwanted bugs if an user creates a new cost function that re-uses some of the old variables rather than copying.