Add plots to tutorials #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmukadam
reviewed
Dec 17, 2021
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "/Users/mukadam/opt/anaconda3/envs/theseus/lib/python3.7/site-packages/theseus/optimizer/nonlinear/nonlinear_optimizer.py:191: RuntimeWarning: There was an error while running the linear optimizer. Original error message: cholesky_cpu: For batch 0: U(1,1) is zero, singular U..\n", |
There was a problem hiding this comment.
There seems to be a weird behavior when running T1 with python 3.7 where the optimization is singular, so step 3 and robust curve fitting don't succeed. This issue goes away when run on python 3.8.
For now I reran both T1 and T2 with 3.8. We should look into this in a separate PR, @luisenp @vshobha.
suddhu
pushed a commit
to suddhu/theseus
that referenced
this pull request
Jan 21, 2023
* Add plots to tutorials * add semicolon to stop spurious matplotlib prints; fix typo; rerun all cells * rerun tutorials 1 and 2 with python 3.8 Co-authored-by: Mustafa Mukadam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some plots to tutorials 1 and 2 to help visualize the data and functions that are being learned, e.g:
