Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: homography estimation - create data folder before downloading data #275

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Bugfix: homography estimation - create data folder before downloading data #275

merged 1 commit into from
Aug 24, 2022

Conversation

luizgh
Copy link
Contributor

@luizgh luizgh commented Aug 24, 2022

Motivation and Context

Fix a bug on the homography estimation example #274

How Has This Been Tested

Followed the steps on bug #274. The examples works after the changes.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 24, 2022
@luisenp
Copy link
Contributor

luisenp commented Aug 24, 2022

Thanks for the fix @luizgh!

@luisenp luisenp merged commit e96bb4f into facebookresearch:main Aug 24, 2022
@mhmukadam mhmukadam linked an issue Aug 24, 2022 that may be closed by this pull request
Minor issue on homography estimation example #274
Closed
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
homography estimation - create data folder before downloading data (f…
01a652d 
…acebookresearch#275)

Co-authored-by: Luiz Gustavo Hafemann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor issue on homography estimation example
3 participants
@luizgh @luisenp @facebook-github-bot